Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox: Fetch patches from the bug tracker. #61247

Closed
wants to merge 1 commit into from

Conversation

ambrop72
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9
Copy link
Member

You can probably remove the comments pointing to the tickets now, I'd say it's clear from the URL

@ambrop72
Copy link
Contributor Author

ambrop72 commented May 10, 2019

It's not obvious how to get to the ticket, one would need to go hunting for the bug tracker URL and entering a ticket number extracted from the attachment URL.

@veprbl
Copy link
Member

veprbl commented May 10, 2019

Why do we want to do this? Since the patches are already in our git, there isn't any benefit to switch to fetching them because the price is already paid.

@ambrop72
Copy link
Contributor Author

ambrop72 commented May 10, 2019

Well there were complaints that they should be fetched, so if this is merged they will be :) I suppose it would benefit channel users which don't get nixpkgs via git. If this is not needed I can close this PR.

@veprbl
Copy link
Member

veprbl commented May 10, 2019

Well there were complaints

Where can we see those?

@ambrop72
Copy link
Contributor Author

#60943 (comment)
Anyway either merge this, or close it.

@veprbl
Copy link
Member

veprbl commented May 10, 2019

Yes, that's right, in the future please try to use fetchpatch whenever possible. It is too late to switch now, because, as I said, those patches are already in nixpkgs git repo. Also it's not a big deal since they are tiny files anyway. Thank you for the effort, though!

@veprbl veprbl closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants