Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: 0.5.7 -> 0.5.8 #61206

Closed
wants to merge 1 commit into from
Closed

solc: 0.5.7 -> 0.5.8 #61206

wants to merge 1 commit into from

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented May 9, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@d-xo d-xo mentioned this pull request May 9, 2019
Merged
endgame
endgame approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine on my machine with:

nix build '(with import (builtins.fetchTarball { url = "https://github.com/dapphub/nixpkgs/archive/solc-0.5.8.tar.gz"; }) {}; pkgs.solc)'

It seems to run ok (at least solc --help); I don't know solidity so I don't have a good test to run.

@asymmetric asymmetric mentioned this pull request May 10, 2019
Merged
10 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented May 10, 2019

There is ongoing work in previous PR #60539

@c0bw3b c0bw3b closed this May 10, 2019
@asymmetric asymmetric deleted the solc-0.5.8 branch May 10, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endgame endgame endgame approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-xo @c0bw3b @endgame