Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate nodePackages #61254

Merged

Conversation

matthew-piziak
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthew-piziak
Copy link
Contributor Author

@ryantm If you could let me know what I should do at this point, that would be great. My first textlint PR just got merged with no ceremony, so I don't know if there's more I should be doing.

@matthew-piziak matthew-piziak force-pushed the regenerate-node-packages-2019-05-10 branch from 1c891d7 to 7c3eb73 Compare May 10, 2019 21:34
@ryantm
Copy link
Member

ryantm commented May 10, 2019

@GrahamcOfBorg build nodePackages.vscode-css-languageserver-bin
@GrahamcOfBorg build nodePackages.vscode-html-languageserver-bin
@GrahamcOfBorg build nodePackages.vue-language-server
@GrahamcOfBorg build nodePackages.bash-language-server
@GrahamcOfBorg build nodePackages.speed-test
@GrahamcOfBorg build nodePackages.typescript-language-server
@GrahamcOfBorg build nodePackages.textlint-plugin-latex
@GrahamcOfBorg build nodePackages.textlint-rule-abbr-within-parentheses
@GrahamcOfBorg build nodePackages.textlint-rule-alex
@GrahamcOfBorg build nodePackages.textlint-rule-common-misspellings
@GrahamcOfBorg build nodePackages.textlint-rule-diacritics
@GrahamcOfBorg build nodePackages.textlint-rule-en-max-word-count
@GrahamcOfBorg build nodePackages.textlint-rule-max-comma
@GrahamcOfBorg build nodePackages.textlint-rule-no-start-duplicated-conjunction
@GrahamcOfBorg build nodePackages.textlint-rule-period-in-list-item
@GrahamcOfBorg build nodePackages.textlint-rule-stop-words
@GrahamcOfBorg build nodePackages.textlint-rule-terminology
@GrahamcOfBorg build nodePackages.textlint-rule-unexpanded-acronym
@GrahamcOfBorg build nodePackages.textlint-rule-write-good
@GrahamcOfBorg build nodePackages.write-good

@ryantm
Copy link
Member

ryantm commented May 10, 2019

@GrahamcOfBorg build nodePackages.vue-language-server

@ryantm ryantm merged commit 6602f32 into NixOS:master May 10, 2019
@matthew-piziak
Copy link
Contributor Author

Thank you!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants