iproute: 5.0.0 -> 5.1.0 #61252
Merged
iproute: 5.0.0 -> 5.1.0 #61252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Most of the new features for this release are in the devlink and rdma utilities. And most of the bug fixes are in fixing the output format glitches that resulted from converting most of the tools to have JSON output." [0] File changes: +share/man/man8/devlink-health.8.gz nix path-info -S: 5.0.0 46661416 5.1.0 46677880 [0]: https://www.spinics.net/lists/netdev/msg569915.html
|
My own tests and the NixOS VM tests (I ran cc @dtzWill: FYI, since you did the last update, but you don't have to test it (I assume you're already busy enough with other stuff). |
c0bw3b
approved these changes
May 13, 2019
|
LGTM, been using myself since you posted :).
Got lost somewhere between "let's be sure works in real situations"
and "it sure does, report to github" :).
Thanks!
…On Mon, 13 May 2019 13:32:09 -0700, Renaud ***@***.***> wrote:
c0bw3b approved this pull request.
Just built iproute2 and tested basic ip/ss/ifstat usage
But in favor on seeing this merged.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#61252 (review) part: text/html
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Please do not merge just yet (or not without testing to be more precise), I will perform some more extensive testing tomorrow.I also added myself as primary maintainer because AFAIK Eelco and Franz are already busy enough with other things and I have some time available (also for issues, etc.) and already committed 2 of the 3 last updates.
The second commit should probably be a separate commit:
The second commit is optional and I'd be interested if there are any objections. The reason for the rename is that the package is actually callediproute2and notiproute:https://en.wikipedia.org/wiki/Iproute2https://packages.debian.org/search?searchon=names&keywords=iproute (iproute is only a phased-out transitional dummy package)https://repology.org/projects/?search=iproutehttps://www.spinics.net/lists/netdev/msg569915.html (actually the subject uses iproute2 while the body starts with iproute :o)Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)