Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py-radix: init at version 0.10.0 #61251

Merged
merged 4 commits into from May 13, 2019
Merged

py-radix: init at version 0.10.0 #61251

merged 4 commits into from May 13, 2019

Conversation

mkgvt
Copy link
Contributor

@mkgvt mkgvt commented May 10, 2019

Motivation for this change

Fixed issues with previous PR #58145.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkgvt mkgvt requested a review from FRidh as a code owner May 10, 2019 20:58
@mkgvt mkgvt mentioned this pull request May 10, 2019
Closed
10 tasks
@mkgvt @c0bw3b
Update pkgs/development/python-modules/py-radix/default.nix
013a8dc 
Co-Authored-By: Renaud <c0bw3b@users.noreply.github.com>
c0bw3b
c0bw3b reviewed May 13, 2019
View reviewed changes
pkgs/development/python-modules/py-radix/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/py-radix/default.nix

src = fetchFromGitHub {
owner = "mjschultz";
repo = "py-radix";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = "py-radix";
repo = pname;

pkgs/development/python-modules/py-radix/default.nix Outdated Show resolved Hide resolved
mkgvt and others added 2 commits May 13, 2019 16:30
@mkgvt @c0bw3b
Update pkgs/development/python-modules/py-radix/default.nix
52851cc 
Co-Authored-By: Renaud <c0bw3b@users.noreply.github.com>
@mkgvt @c0bw3b
Update pkgs/development/python-modules/py-radix/default.nix
70d4f8b 
Co-Authored-By: Renaud <c0bw3b@users.noreply.github.com>
c0bw3b
c0bw3b approved these changes May 13, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 61251 1

2 package were build:
  • python27Packages.py-radix
  • python37Packages.py-radix

@c0bw3b c0bw3b merged commit 715dfd0 into NixOS:master May 13, 2019
@mkgvt mkgvt deleted the py-radix branch May 14, 2019 13:05
tadeokondrak pushed a commit to tadeokondrak/nixpkgs that referenced this pull request May 17, 2019
@mkgvt @tadeokondrak
py-radix: init at version 0.10.0 (NixOS#61251)
cb7cc6f 
* py-radix: init at version 0.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkgvt @c0bw3b @mkgardner