pythonPackages.bjoern: fix test result checking #62055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_wsgi_compliance.py returns a zero exit status unconditionally - to check for a failure we need to grep the stdout. it also appears this test is broken upstream for py27.
marsam
reviewed
May 26, 2019
| @@ -13,7 +13,8 @@ buildPythonPackage rec { | |||
|
|
|||
| checkPhase = '' | |||
| ${python.interpreter} tests/keep-alive-behaviour.py 2>/dev/null | |||
| ${python.interpreter} tests/test_wsgi_compliance.py | |||
| '' + stdenv.lib.optionalString isPy3k '' | |||
| ${python.interpreter} tests/test_wsgi_compliance.py | (! grep -i "fail") | |||
There was a problem hiding this comment.
IMHO, this should be handled upstream. Currently it just print the message https://github.com/jonashaag/bjoern/blob/3.0.0/tests/test_wsgi_compliance.py#L39-L45
There was a problem hiding this comment.
Absolutely (upstream issue jonashaag/bjoern#158), but in the meantime the way we have the tests setup now, something breaking test_wsgi_compliance.py in a more serious way won't get picked up at all.
|
Upstream issue has been closed, so maybe just add jonashaag/bjoern@eaca4b5 as a patch here. We then can probably merge #61887 |
|
Hmm no such luck I'm afraid - applying that patch to either 2.2.3 or 3.0.0 causes the py37 tests to fail. (of course we could always conditionally apply the patch :) |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When testing #61887 noticed
test_wsgi_compliance.pyreturns a zero exit status unconditionally - to check for a failure we need to grep the stdout. It also appears this test is broken upstream for py27 - I should open an issue with them...Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)