Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains batch update #61920

Merged
merged 10 commits into from May 26, 2019
Merged

jetbrains batch update #61920

merged 10 commits into from May 26, 2019

Conversation

sonercirit
Copy link
Contributor

@sonercirit sonercirit commented May 23, 2019

Updated with update.pl, have not tested the packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sonercirit sonercirit requested a review from edwtjo as a code owner May 23, 2019 00:38
@sonercirit sonercirit changed the title jetbrains jetbrains batch update May 23, 2019
@infinisil
Copy link
Member

@GrahamcOfBorg build jetbrains.clion
@GrahamcOfBorg build jetbrains.datagrip
@GrahamcOfBorg build jetbrains.goland
@GrahamcOfBorg build jetbrains.idea-community
@GrahamcOfBorg build jetbrains.idea-ultimate
@GrahamcOfBorg build jetbrains.phpstorm
@GrahamcOfBorg build jetbrains.pycharm-community
@GrahamcOfBorg build jetbrains.pycharm-professional
@GrahamcOfBorg build jetbrains.ruby-mine
@GrahamcOfBorg build jetbrains.webstorm

@sonercirit
Copy link
Contributor Author

@infinisil seems like these tests won't run because of allowUnfree option.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@infinisil
Copy link
Member

Yeah, but at least it did the builds for a couple of them (if you scroll down in the checks list at the bottom)

@sonercirit
Copy link
Contributor Author

@infinisil , @edwtjo any updates on this?

@sonercirit
Copy link
Contributor Author

also @c0bw3b since he merged the last one :)

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 61920 1

10 package were build:
  • jetbrains.clion
  • jetbrains.datagrip
  • jetbrains.goland
  • jetbrains.idea-community
  • jetbrains.idea-ultimate
  • jetbrains.phpstorm
  • jetbrains.pycharm-community
  • jetbrains.pycharm-professional
  • jetbrains.ruby-mine
  • jetbrains.webstorm

@c0bw3b c0bw3b merged commit dd6c797 into NixOS:master May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants