Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libheif: add patch for CVE-2019-11471 #61919

Closed
wants to merge 1 commit into from
Closed

libheif: add patch for CVE-2019-11471 #61919

wants to merge 1 commit into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 23, 2019

Motivation for this change

Should resolve #60839

Needed a bit of modification from upstream changeset.

Unfortunately this project doesn't have any fixed tests as such.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from gebner May 23, 2019 00:31
@risicle risicle changed the base branch from master to staging May 23, 2019 00:33
@risicle risicle force-pushed the ris-libheif-CVE-2019-11471 branch from a415a9a to 355ce18 Compare May 23, 2019 00:34
vcunat pushed a commit that referenced this pull request May 23, 2019
@risicle @vcunat
libheif: add patch for CVE-2019-11471 (PR #61919)
9c4d318
@vcunat
Copy link
Member

vcunat commented May 23, 2019

Pushed to master directly 9c4d318, as the amount of rebuild is quite low (a couple hundred altogether).

@vcunat vcunat closed this May 23, 2019
@risicle risicle mentioned this pull request May 24, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @vcunat