Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6c167db60279
Choose a base ref
...
head repository: solvespace/solvespace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9faa7cb0ca1f
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 24, 2019

  1. Fix commit cc10788.

    @whitequark
    whitequark committed May 24, 2019
    Copy the full SHA
    9faa7cb View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/mesh.cpp
4 changes: 2 additions & 2 deletions src/mesh.cpp
View file
Original file line number Diff line number Diff line change
@@ -186,15 +186,15 @@ void SMesh::Simplify(int start) {
if(fabs(bDot) < LENGTH_EPS && fabs(dDot) < LENGTH_EPS) {
conv[WRAP((j+1), convc)] = c;
// and remove the vertex at j, which is a dup
std::move(conv+j+1, conv+convc, conv+(convc-1));
std::move(conv+j+1, conv+convc, conv+j);
convc--;
} else if(fabs(bDot) < LENGTH_EPS && dDot > 0) {
conv[j] = c;
} else if(fabs(dDot) < LENGTH_EPS && bDot > 0) {
conv[WRAP((j+1), convc)] = c;
} else if(bDot > 0 && dDot > 0) {
// conv[j] is unchanged, conv[j+1] goes to [j+2]
std::move_backward(conv+j+1, conv+convc, conv+j+2);
std::move_backward(conv+j+1, conv+convc, conv+convc+1);
conv[j+1] = c;
convc++;
} else {