Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.mathcomp: 1.8.0 -> 1.9.0 and adding real-closed #61959

Closed
wants to merge 1 commit into from
Closed

coqPackages.mathcomp: 1.8.0 -> 1.9.0 and adding real-closed #61959

wants to merge 1 commit into from

Conversation

CohenCyril
Copy link
Contributor

Motivation for this change

Adding mathcomp version 1.9.0 and mathcomp-real-closed versions 1.0.1 and 1.0.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril
Copy link
Contributor Author

@vbgl could you trigger builds?

@vbgl
Copy link
Contributor

vbgl commented May 23, 2019 •
edited

oops…

@vbgl
Copy link
Contributor

vbgl commented May 23, 2019

@GrahamcOfBorg build coqPackages.mathcomp

@CohenCyril
Copy link
Contributor Author

CohenCyril commented May 23, 2019 •
edited

you may also want to buid coqPackages_8_10.mathcomp and coqPackages.mathcomp_1_8-real-closed

@vbgl
Copy link
Contributor

vbgl commented May 23, 2019

@GrahamcOfBorg build coqPackages_8_10.mathcomp

@vbgl
Copy link
Contributor

vbgl commented May 23, 2019

@GrahamcOfBorg build coqPackages.mathcomp-real-closed

@CohenCyril
Copy link
Contributor Author

coqPackages.mathcomp-real-closed

this one does not exist yet, try coqPackages.mathcomp_1_8-real-closed instead

@vbgl
Copy link
Contributor

vbgl commented May 23, 2019

@GrahamcOfBorg build coqPackages.mathcomp_1_8-real-closed

@CohenCyril
Copy link
Contributor Author

coqPackages.mathcomp on x86_64-darwin — Failure

@vbgl is this important and if so do you know why there is a failure?

@vbgl
Copy link
Contributor

vbgl commented May 23, 2019

The failure is: “fork: Resource temporarily unavailable”. The CI machine seems overloaded.

@CohenCyril
Copy link
Contributor Author

@vbgl I did some improvements, including releases of mathcomp finmap and analysis and filtering some invalid mathcomp extra packages that I let through for incompatible versions of Coq by mistake.

@CohenCyril
Copy link
Contributor Author

@vbgl is there an obstacle to merge this one?

@vbgl
Copy link
Contributor

vbgl commented Jun 3, 2019

Merged as 5474660

@vbgl vbgl closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: coq 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CohenCyril @vbgl