Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: Allow passing packages to add to PATH #61999

Merged
merged 1 commit into from May 29, 2019
Merged

neovim: Allow passing packages to add to PATH #61999

merged 1 commit into from May 29, 2019

Conversation

Jomik
Copy link
Contributor

@Jomik Jomik commented May 24, 2019 •
edited

Motivation for this change

I need to add packages to my path that some of my vim plugins use.
The only way to do this is overriding the unwrapped neovim, and then adding them to the path there, but then I have to rebuild neovim, which is not optimal, especially since we have a wrapper.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented May 24, 2019 •
edited

Maybe we should (also/instead) add a makeWrapperArgs parameter?

@Jomik
Copy link
Contributor Author

Jomik commented May 24, 2019 •
edited

Maybe we should (also/instead) add a makeWrapperArgs parameter?

That seems like a good idea, tbh, since this expression is a wrapper, it makes sense that you can add more args to it. 👍

@teto
Copy link
Member

teto commented May 28, 2019

doing so you wouldn't need extraPackages anymore as you could just --prefix PATH. Could you update the PR ?

@Jomik Jomik force-pushed the feature-neovim-extraPackages branch from e1d31fe to f51b433 Compare May 29, 2019 08:43
@Jomik
Copy link
Contributor Author

Jomik commented May 29, 2019

@teto Done 👍

@teto teto merged commit dbb27af into NixOS:master May 29, 2019
@teto
Copy link
Member

teto commented May 29, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jomik @FRidh @teto