Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytcc: init at 1.8.1 #61998

Merged
merged 1 commit into from May 26, 2019
Merged

ytcc: init at 1.8.1 #61998

merged 1 commit into from May 26, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change

found this software, which appear to be really interessing. modified the gallery-dl installation instruction

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested the ability to list unwatched video with this software.

@marius851000
Copy link
Contributor Author

@GrahamcOfBorg build ytcc

pkgs/tools/networking/ytcc/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/ytcc/default.nix Outdated Show resolved Hide resolved
@marius851000
Copy link
Contributor Author

@aanderse

@aanderse
Copy link
Member

@GrahamcOfBorg build ytcc

@aanderse aanderse merged commit 1316e4a into NixOS:master May 26, 2019
@aanderse
Copy link
Member

@marius851000 Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants