Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Po4a: 0.47 -> 0.55 #62060

Merged
merged 1 commit into from May 25, 2019
Merged

perlPackages.Po4a: 0.47 -> 0.55 #62060

merged 1 commit into from May 25, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 25, 2019

Motivation for this change

This Perl module was outdated and its sources moved to GitHub.
+ it was broken because the shebang of perl scripts under bin was wrong ; apt builds are failing on Hydra because of that

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
perlPackages.Po4a: 0.47 -> 0.55
2e900c9 
+ refresh meta.homepage
@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 25, 2019

Complete changelog:
https://github.com/mquinson/po4a/releases
-or-
https://github.com/mquinson/po4a/blob/v0.55/NEWS

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 25, 2019

Result of nix-review pr 62060 on NixOS

6 package were build:
  • apt
  • autofs5
  • modem-manager-gui
  • perl528Packages.Po4a
  • sssd
  • tilix

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 25, 2019

@GrahamcOfBorg build perl528Packages.Po4a apt

@c0bw3b c0bw3b merged commit e2d1da7 into NixOS:master May 25, 2019
@c0bw3b c0bw3b deleted the pkg/perl-po4a branch May 25, 2019 17:06
peti pushed a commit that referenced this pull request May 27, 2019
@c0bw3b @peti
perlPackages.Po4a: 0.47 -> 0.55 (#62060)
ad316d7 
+ refresh meta.homepage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@c0bw3b