Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show units of dimensions in more precise way #227

Closed
Evil-Spirit opened this issue Apr 6, 2017 · 5 comments
Closed

Show units of dimensions in more precise way #227

Evil-Spirit opened this issue Apr 6, 2017 · 5 comments

Comments

@Evil-Spirit
Copy link
Collaborator

Evil-Spirit commented Apr 6, 2017

This commit introduces units in meters Evil-Spirit@bc3e7a2
This Evil-Spirit@202c6fb is experiments with si prefixes and formatting

2017-04-06 20 08 41
2017-04-06 20 10 42
2017-04-06 20 12 03

@whitequark
Copy link
Contributor

Thank you for this excellent feature! I've merged the "dimensions in meters" patch in master. Do you think you could add "Dimensions with _S_I prefixes" as another menu option? This seems to be more in line with the rest of the options.

@whitequark whitequark added UI and removed UI labels Jul 12, 2018
@Evil-Spirit
Copy link
Collaborator Author

You mean to make this feature as option to have ability to switch it off?

@whitequark
Copy link
Contributor

I mean it makes sense to have separate options for "dimensions in mm" (for ISO technical drawings), "dimensions in m" (for architectural drawings) and "dimensions in metric with SI prefixes" (for unusual drawings where very large, very small or very different units are present). This is because most technical drawings have all length dimensions with the same units to make it less likely that e.g. someone misreads "mm" as "m" or maybe "cm".

@ghost
Copy link

ghost commented Jul 28, 2018

Thank you for this excellent feature! I've merged the "dimensions in meters" patch in master.

@whitequark, would you also merge "don't show zeroes" option? It would be useful for all dimensions, especially Angle constraints.

@whitequark
Copy link
Contributor

whitequark commented May 24, 2019

@Evil-Spirit Thank you, merged in 9d1c295, with many changes:

  • Added cm;
  • Added imperial units (mil, µin);
  • Changed formatting to use round-to-even, to match labels displayed with SI units off;
  • Adjusted measurement tools to always use SI prefixes, because 400000000 mm³ is not a useful value;
  • Overall simplification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants