Clang format #416
Clang format #416
Conversation
This would add a lot of noise to the history, etc. if applied all-over now. Use git clang-tidy to apply it solely to your changes.
This is how you enforce the "wrap all blocks with {}, even one-liners".
Use something like this (-fix is optional):
> run-clang-tidy-7 -p build -fix src/*.cpp src/*.h
Thanks for investigating this. I don't think it's a very important guideline, and I appear to have significantly overestimated how often that's the case when writing CONTRIBUTING.md. So, let's just drop it instead, in CONTRIBUTING.md as well, as if I understand you correctly, that means we don't really need clang-tidy anymore without it (is that right?) |
|
Well, certainly not to enforce code style. It's a decent idea to run from time to time as a linter. |
|
I pushed the clang-format change as ffef006 and updated CONTRIBUTING.md, thank you very much. I might look into clang-tidy some time later but for now let's omit it. |
|
Thanks! |
Follow-up from #414 - this is my best attempt at getting one using my typical approach of populating with the explicitly-stated preferences, then iterating through "apply to file" and "correct config causing most apparent spurious changes". There are substantial inconsistencies that mean that whatever decision I make for some of these, it will introduce changes if it were applied all-over, but since that's not on the table anyway, this should be at least something. There were also a few where clang-format couldn't quite express the subtle distinctions I saw in the existing formatting, so I picked the overall less-intrusive one.
The file is commented to help you modify it as desired.
I also added a clang-tidy config file because the contributing doc says "braces around all the things" and that's not something clang-format can do (for some reason), you have to use clang-tidy. Doing so exposed me to the reality that it's a guideline very rarely followed - but if you'd like to enforce it, that clang-tidy file is a good way to do so. Something like this, assuming you have a build tree in
build/...(Can't use run-clang-tidy here because it will result in things getting multiple sets of brackets, etc. Sadly must do it single-threaded like this, or have it save out the fixes and manually choose the ones to apply.)