Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle intersections do not split properly #147

Open
pretentiousgit opened this issue Jan 1, 2017 · 7 comments
Open

Circle intersections do not split properly #147

pretentiousgit opened this issue Jan 1, 2017 · 7 comments

Comments

@pretentiousgit
Copy link

pretentiousgit commented Jan 1, 2017

System information

SolveSpace version: 2.3

Operating system: Mac OSX El Cap 10.11.4

Expected behavior

Select two circles and click "split lines/curves where they intersect"

Expected results might be:
-- four arcs, with two points where they intersect
-- Two arcs joined at end points with inner lines removed

Actual behavior

Single data point connecting two circles appear.
screen shot 2017-01-01 at 4 44 42 pm

Additional information

circleBug.slvs.zip

@ohsix
Copy link

ohsix commented Jan 1, 2017

tried this on master and it DTRT, circles look finer here though

in configuration what do you have chord tolerance and max piecewise linear segments set to?

(not a developer, just saw something i could try)

@pretentiousgit
Copy link
Author

Just have out of the box settings - haven't messed with things at all. Not sure if it's a valid bug or if I missed a step in the tutorial/the intent.

@whitequark whitequark added the bug label Jan 1, 2017
@Evil-Spirit
Copy link
Collaborator

This work as excepted, intersection routine just create exactly one intersection per call, so label should be enhancement at least

@Evil-Spirit
Copy link
Collaborator

Also, this sould work with the list of entities

@whitequark
Copy link
Contributor

I think we should just document that one may need to use the tool multiple times, if several intersections are desired.

@whitequark whitequark removed this from todev in Evil-Spirit tasks Mar 12, 2017
@Evil-Spirit
Copy link
Collaborator

@whitequark, actually there is no problem to implement this.

@whitequark
Copy link
Contributor

@Evil-Spirit OK, if it's easy please write a patch

@whitequark whitequark modified the milestones: 2.3, 3.0 May 23, 2019
@whitequark whitequark removed their assignment May 23, 2019
@whitequark whitequark removed this from the 3.0 milestone Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants