Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustup: 1.18.2 -> 1.18.3 #61937

Merged
merged 1 commit into from May 24, 2019
Merged

rustup: 1.18.2 -> 1.18.3 #61937

merged 1 commit into from May 24, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented May 23, 2019

Motivation for this change

changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Mic92 May 23, 2019 08:17
@dywedir dywedir force-pushed the rustup branch 2 times, most recently from dcdcc05 to 6d40813 Compare May 23, 2019 11:40
@Mic92 Mic92 merged commit 1c95cad into NixOS:master May 24, 2019
@dywedir dywedir deleted the rustup branch May 24, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @marsam @Mic92