systemd-boot service: don't remove directories from EFI dir #62065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch is trivial but I'd still like somebody's review before merging just to be sure we won't break boot accidentally. |
|
@GrahamcOfBorg test installer.simpleUefiSystemdBoot The change is trivial after all so if the test passes I'm going to merge this. |
This will only result in an error. These directories might be created by, for example, fwupdmgr.
abbradar
force-pushed
the
systemd-boot-fwupdmgr
branch
from
f70c488
to
517603d
Compare
|
@GrahamcOfBorg test installer.simpleUefiSystemdBoot |
|
Should not we delete the directories as outlined here instead? |
|
I think we should treat this conservatively. Directories were created definitely not by us and for some reason. For example if someone runs fwupdmgr and then nixos-rebuild the firmware capsule will be removed which is not what we want.
…On June 7, 2019 5:45:15 PM GMT+03:00, Jan Tojnar ***@***.***> wrote:
Should not we delete the directories as outlined
[here](#39386 (comment))
instead?
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#62065 (comment)
--
Nikolay.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only result in an error. These directories might be created by, for example, fwupdmgr.
Motivation for this change
Fix crashes after using fwupdmgr to update BIOS.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)