Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turses: switch back to python 3.7 #61984

Merged
merged 1 commit into from Sep 21, 2019
Merged

turses: switch back to python 3.7 #61984

merged 1 commit into from Sep 21, 2019

Conversation

booxter
Copy link
Contributor

@booxter booxter commented May 24, 2019

No description provided.

@ofborg ofborg bot requested a review from garbas May 24, 2019 06:10
FRidh
FRidh requested changes May 24, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

motivation is missing from commit msg

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@booxter any updates please?

@booxter
Copy link
Contributor Author

booxter commented Sep 20, 2019

@mmahut @FRidh I thought getting rid of older python builds is a motivation itself because it eventually allows to not ship / install older language stack + removes a special case in the turses package. But if it's not, then this should be closed.

@FRidh
Copy link
Member

FRidh commented Sep 21, 2019

Yes, you are right about that, however, your commit message says "switch back..." which implies it was done for a reason. Does that reason no longer apply then? It's just a matter of communication here.

@Mic92
Copy link
Member

Mic92 commented Sep 21, 2019

i.e: Fix python3.7 support

@Mic92 Mic92 merged commit 3a9cb10 into NixOS:master Sep 21, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 21, 2019
@booxter @dtzWill
turses: fix python3.7 support (NixOS#61984)
13ee349 
(cherry picked from commit 3a9cb10)
(let's try not pulling in glibcLocales, maybe works now...? ;D)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@booxter @mmahut @FRidh @Mic92