Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadowfox: 1.7.20 -> 2.0.1 #61924

Merged
merged 2 commits into from May 24, 2019
Merged

shadowfox: 1.7.20 -> 2.0.1 #61924

merged 2 commits into from May 24, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 23, 2019

Motivation for this change

https://github.com/SrKomodo/shadowfox-updater/releases/tag/v2.0.0
https://github.com/SrKomodo/shadowfox-updater/releases/tag/v2.0.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame
Copy link
Contributor

endgame commented May 23, 2019

Builds on my machine:

nix build '(with import (builtins.fetchTarball { url = "https://github.com/dtzWill/nixpkgs/archive/update/shadowfox-2.0.1.tar.gz"; }) {}; pkgs.shadowfox)'

shadowfox-updater seems to run:

$ ./result/bin/shadowfox-updater --help
Usage of ./result/bin/shadowfox-updater:
  -generate-uuids
    	Wheter to automatically generate UUIDs or not
  -profile-index int
    	Index of profile to use
  -profile-name string
    	Name of profile to use, if not defined or not found will fallback to profile-index
  -set-dark-theme
    	Wheter to automatically set Firefox's dark theme
  -uninstall
    	Wheter to install or uninstall ShadowFox

compiler doesn't work, should it?

$ ./result/bin/compiler --help
panic: exec: "go": executable file not found in $PATH

goroutine 1 [running]:
main.checkErr(...)
	/build/source/compiler/main.go:10
main.main()
	/build/source/compiler/main.go:36 +0x4cf

@ofborg ofborg bot requested review from kalbasit and infinisil May 23, 2019 02:04
@infinisil
Copy link
Member

@endgame Thanks, it seems that the compiler binary is only used by the projects CI. I pushed a commit to remove it.

@infinisil infinisil merged commit 82776c3 into NixOS:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @endgame @infinisil