Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xterm: 344 -> 345 #61925

Merged
merged 1 commit into from May 24, 2019
Merged

xterm: 344 -> 345 #61925

merged 1 commit into from May 24, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 23, 2019

Motivation for this change

https://invisible-island.net/xterm/xterm.log.html#xterm_345

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vrthra May 23, 2019 02:01
tomberek
tomberek approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs on Ubuntu.
Did NOT test on Darwin. Note ofborg failure.

@mmahut
Copy link
Member

mmahut commented May 23, 2019

Any way to ask the borg queen to run this again?

./configure: fork: Resource temporarily unavailable

@mmahut
Copy link
Member

mmahut commented May 23, 2019

@GrahamcOfBorg eval

@grahamc
Copy link
Member

grahamc commented May 23, 2019

@GrahamcOfBorg build xterm

@infinisil
Copy link
Member

Can confirm it builds on my mac

@infinisil infinisil merged commit daedc80 into NixOS:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @mmahut @grahamc @infinisil @tomberek