Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strace: 5.0 -> 5.1 #61927

Merged
merged 1 commit into from May 23, 2019
Merged

strace: 5.0 -> 5.1 #61927

merged 1 commit into from May 23, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 23, 2019

Motivation for this change

https://strace.io/files/5.1/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from globin May 23, 2019 02:30
@c0bw3b
Copy link
Contributor

c0bw3b commented May 23, 2019

I tried re-running the check phase but it still fails 2 tests:

ioprio-Xverbose.gen.test: failed test: ../../strace -a18 -e trace=ioprio_get,ioprio_set -Xverbose ../ioprio-Xverbose output mismatch
FAIL ioprio-Xverbose.gen.test (exit status: 1)
[...]
strace-log-merge-suffix.test: failed test: strace-log-merge output mismatch
FAIL strace-log-merge-suffix.test (exit status: 1)

Also noticed it's slightly faster to build with enableParallelBuilding = true;
Otherwise it builds fine on nixos.

mmahut
mmahut approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without failure
  • tested the binary

@globin globin merged commit 3db2e20 into NixOS:master May 23, 2019
@globin
Copy link
Member

globin commented May 23, 2019

Darwin was broken previously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @c0bw3b @globin @mmahut