Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.signal-desktop: add test #61916

Merged
merged 1 commit into from May 23, 2019
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 22, 2019

Motivation for this change

This adds a test up starting signal-desktop, and runs OCR to see we're asked to link our phone to it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from primeos May 22, 2019 22:59
@flokli flokli mentioned this pull request May 22, 2019
10 tasks
@flokli flokli merged commit 1e73929 into NixOS:master May 23, 2019
@flokli flokli deleted the signal-desktop-test branch May 23, 2019 13:59
@flokli
Copy link
Contributor Author

flokli commented May 24, 2019

backported to 19.03 in 5695696.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant