Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gallery-dl : 1.8.3 -> 1.8.4 #61992

Merged
merged 1 commit into from May 25, 2019
Merged

gallery-dl : 1.8.3 -> 1.8.4 #61992

merged 1 commit into from May 25, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change
Things done

updated to 1.8.4, the 1.8.3 containing a crash while writing metadata to file

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marius851000
Copy link
Contributor Author

@GrahamcOfBorg build gallery-dl

@marius851000
Copy link
Contributor Author

@dawidsowa

tomberek
tomberek approved these changes May 25, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions as expected on Ubuntu

@Mic92 Mic92 merged commit 733baa4 into NixOS:master May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marius851000 @tomberek @Mic92