Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp-gsl: remove in favor of microsoft_gsl #61994

Merged
merged 1 commit into from May 29, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

It's the same package twice but cpp-gsl is older.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I actually like the name cpp-gsl better because that's what matters here.
When people are looking for the C++ GSL (GuidelinesSupportLibrary) they'd first try gsl (which is a GNU project) and then look for something that says cpp. With a header only free-software library people probably don't care whether it comes from Microsoft or not, considering there is no alternative implementation (I'm aware of).

It's the same package twice but cpp-gsl is older.
@FRidh
Copy link
Member

FRidh commented May 25, 2019

cc @yuriaisaka

@joachifm
Copy link
Contributor

@GrahamcOfBorg build cpp-gsl

@joachifm joachifm merged commit e8445a3 into NixOS:master May 29, 2019
@joachifm
Copy link
Contributor

Makes sense to me

@JohnAZoidberg JohnAZoidberg deleted the remove-cpp-gsl branch May 29, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants