cpp-gsl: remove in favor of microsoft_gsl #61994
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's the same package twice but cpp-gsl is older.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)I actually like the name
cpp-gsl
better because that's what matters here.When people are looking for the C++ GSL (GuidelinesSupportLibrary) they'd first try
gsl
(which is a GNU project) and then look for something that says cpp. With a header only free-software library people probably don't care whether it comes from Microsoft or not, considering there is no alternative implementation (I'm aware of).