Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cocoapods: define updateScript #61934

Merged
merged 1 commit into from May 24, 2019
Merged

cocoapods: define updateScript #61934

merged 1 commit into from May 24, 2019

Conversation

lilyball
Copy link
Member

Motivation for this change

This means nix-shell maintainers/scripts/update.nix --argstr maintainer lilyball will update cocoapods.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/automating-updates-of-ruby-packages/2996/3

@lilyball
Copy link
Member Author

lilyball commented May 23, 2019 •
edited

I've updated this PR to use an alternative approach that avoids the need for writeScript.

@infinisil infinisil merged commit 2440863 into NixOS:master May 24, 2019
@infinisil
Copy link
Member

Nice, didn't know about maintainers/scripts/update.nix

@lilyball lilyball deleted the cocoapods-update-script branch May 24, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @nixos-discourse @infinisil