@bignaux, please review.

Added missing dependency to hicolor-icon-theme. Homepage is in place pointing to the product web site. And it is still plain stdenv.mkDerivation instead of qt5.callPackage as it seems there are only couple of packages doing it this way while the rest is more conventional.

@aanderse, @bignaux please review. I addressed some you your comments.

@kuznero by no means required, but bonus points for submitting desktop item upstream 😄

@kuznero by no means required, but bonus points for submitting desktop item upstream smile

Not sure I follow, could you please elaborate?

It appears that upstream vnote has no desktop item so you created one specially for nixpkgs using makeDesktopItem. If you made a PR against upstream vnote adding the generated desktop item then we wouldn't need to provide our own desktop item with nixpkgs in a future release, other distros would benefit from it, etc... These types of files really belong upstream.

But I really want to make it clear this isn't required, it's just an awesome extra step you could take if you were so inclined to do so.

@GrahamcOfBorg build vnote

I see, thanks for clarification! I will keep it this way for now as I cannot commit to it yet. But I might get back to it later when I have more time.