Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-wrapper: stop creating new profiles when the binary path changes #61980

Merged
merged 1 commit into from May 24, 2019
Merged

firefox-wrapper: stop creating new profiles when the binary path changes #61980

merged 1 commit into from May 24, 2019

Conversation

andir
Copy link
Member

@andir andir commented May 23, 2019

Motivation for this change

With a recent change to firefox (that landed in 67) a new profile is
created whenever the install location changes. Since our install
location (the binary path) always changes when we do a new build it is
rather annoying.

Setting the environment variable SNAP_NAME to firefox is supposed to
workaround the issue.

related to #58923

Woarkound taken from rail/nixos-configs@1ff8b6c

cc @rail

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
firefox-wrapper: stop creating new profiles when the binary path changes
082ed38 
With a recent change to firefox (that landed in 67) a new profile is
created whenever the install location changes. Since our install
location (the binary path) always changes when we do a new build it is
rather annoying.

Setting the environment variable `SNAP_NAME` to `firefox` is supposed to
workaround the issue.

related to NixOS#58923

Woarkound taken from rail/nixos-configs@1ff8b6c

cc @rail
@andir andir mentioned this pull request May 23, 2019
Closed
@flokli flokli merged commit f7640e3 into NixOS:master May 24, 2019
@flokli
Copy link
Contributor

flokli commented May 24, 2019 •
edited

backported to 19.03 in c574f78.

@rail
Copy link

rail commented May 24, 2019

Thank you!

@taku0 taku0 mentioned this pull request Aug 31, 2019
Merged
10 tasks
@layus layus mentioned this pull request Jul 10, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @flokli @rail