Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcanberra: fix crashes with wayland #62031

Closed
wants to merge 1 commit into from
Closed

libcanberra: fix crashes with wayland #62031

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 24, 2019 •
edited by ghost

Import patch from upstream, to fix crashes on non X11 Gdk backends.

http://git.0pointer.net/libcanberra.git/commit/?id=c0620e432650e81062c1967cc669829dbd29b310
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=820944

Without this patch, pavucontrol segfaults when changing the output volume on wayland:

Thread 1 ".pavucontrol-wr" received signal SIGSEGV, Segmentation fault.
0x00007ffff75a7e4e in _XInternAtom () from /nix/store/69vq0a9sqynmz335apm8zgyjdmq34s5j-libX11-1.6.7/lib/libX11.so.6
(gdb) bt
#0  0x00007ffff75a7e4e in _XInternAtom () from /nix/store/69vq0a9sqynmz335apm8zgyjdmq34s5j-libX11-1.6.7/lib/libX11.so.6
#1  0x00007ffff75a81ea in XInternAtom () from /nix/store/69vq0a9sqynmz335apm8zgyjdmq34s5j-libX11-1.6.7/lib/libX11.so.6
#2  0x00007ffff6df633d in gdk_x11_atom_to_xatom_for_display () from /nix/store/8j8abxvdh65wqdqffkmfs5dhryfsfa3j-gtk+3-3.24.8/lib/libgdk-3.so.0
#3  0x00007ffff76bbb69 in ca_gtk_proplist_set_for_widget ()
   from /nix/store/hj1sx0rqd0ci5cxr5yi1q3q8qgiaja6d-libcanberra-0.30/lib/libcanberra-gtk3.so.0
#4  0x00007ffff76bc596 in ca_gtk_play_for_widget () from /nix/store/hj1sx0rqd0ci5cxr5yi1q3q8qgiaja6d-libcanberra-0.30/lib/libcanberra-gtk3.so.0
#5  0x000000000043b8e8 in SinkWidget::executeVolumeUpdate() ()
#6  0x0000000000435126 in DeviceWidget::timeoutEvent() ()
#7  0x00007ffff77592a2 in (anonymous namespace)::glibmm_source_callback(void*) ()
   from /nix/store/0n0h6g5bbnhwi5j2nnha1x8x73a8l72m-glibmm-2.60.0/lib/libglibmm-2.4.so.1
#8  0x00007ffff685b5fb in g_timeout_dispatch () from /nix/store/yrmrvha03pvdyi9ww2bi6xjpk5930sf8-glib-2.60.1/lib/libglib-2.0.so.0
#9  0x00007ffff685a625 in g_main_context_dispatch () from /nix/store/yrmrvha03pvdyi9ww2bi6xjpk5930sf8-glib-2.60.1/lib/libglib-2.0.so.0
#10 0x00007ffff685aa80 in g_main_context_iterate.isra () from /nix/store/yrmrvha03pvdyi9ww2bi6xjpk5930sf8-glib-2.60.1/lib/libglib-2.0.so.0
#11 0x00007ffff685ac5c in g_main_context_iteration () from /nix/store/yrmrvha03pvdyi9ww2bi6xjpk5930sf8-glib-2.60.1/lib/libglib-2.0.so.0
#12 0x00007ffff6a8056d in g_application_run () from /nix/store/yrmrvha03pvdyi9ww2bi6xjpk5930sf8-glib-2.60.1/lib/libgio-2.0.so.0
#13 0x00000000004309c9 in main ()
(gdb)
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes May 28, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you need to include the link to the commit upstream as @Mic92 mentioned.

@ghost
Copy link
Author

ghost commented May 28, 2019

Oh, I thought I should include it in the commit message. Will add a comment in a moment.

@worldofpeace
Copy link
Contributor

Guess their was a way to apply patches with different -p* which was literally doing it manually.

Superseded by #62184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @Mic92