Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
base: 88879d352eb4
Choose a base ref
...
head repository: solvespace/solvespace
compare: 549565958ff3
Choose a head ref
  • 2 commits
  • 7 files changed
  • 1 contributor

Commits on May 24, 2019

  1. Remove forceDofCheck parameter from SolveRank(). NFC. 

    It makes no sense to solve by substitution (therefore weakening rank
check) in SolveRank(), since that's the whole point of SolveRank().

In addition, because SolveRank() is currently always called right
after AddConstraint(), forceDofCheck would always be true anyway.

In addition, it makes no sense to have TestRankForGroup() dependent
on the result of the previous solve. (For SolveGroup(), solving by
substitution after we know that rank test succeeds makes dragging
points much faster.)
    @whitequark
    whitequark committed May 24, 2019
    Copy the full SHA
    394c1f6 View commit details
    Browse the repository at this point in the history

  2. Skip creating an automatic H/V constraint if it would be redundant. 

    This means that automatically added H/V constraints now will never
cause the sketch to become overconstrained, which currently makes
that feature almost unusable.
    @whitequark
    whitequark committed May 24, 2019
    Copy the full SHA
    5495659 View commit details
    Browse the repository at this point in the history