Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.virtualboxGuestAdditions: don't install VBoxOGL for now #61944

Merged
merged 1 commit into from May 26, 2019
Merged

linuxPackages.virtualboxGuestAdditions: don't install VBoxOGL for now #61944

merged 1 commit into from May 26, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 23, 2019

It seems to be broken upstream too, and fixing it is far down the
priority list:
https://www.virtualbox.org/pipermail/vbox-dev/2017-June/014561.html
Additionally, 3d support seems to rely on VBoxOGL.so being symlinked
from libGL.so (which we can't), and Oracle doesn't plan on supporting
libglvnd either. (#18457)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
linuxPackages.virtualboxGuestAdditions: don't install VBoxOGL for now
8b34ec4 
It seems to be broken upstream too, and fixing it is far down the
priority list:
https://www.virtualbox.org/pipermail/vbox-dev/2017-June/014561.html
Additionally, 3d support seems to rely on VBoxOGL.so being symlinked
from libGL.so (which we can't), and Oracle doesn't plan on supporting
libglvnd either. (NixOS#18457)
@flokli flokli mentioned this pull request May 23, 2019
Closed
@ofborg ofborg bot requested a review from svanderburg May 23, 2019 13:04
infinisil
infinisil approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@flokli flokli marked this pull request as ready for review May 24, 2019 21:44
@flokli
Copy link
Contributor Author

flokli commented May 24, 2019

@GrahamcOfBorg build nixosTests.virtualbox

@flokli flokli merged commit fa6c93a into NixOS:master May 26, 2019
@flokli flokli deleted the disable-vboxogl branch May 26, 2019 10:30
@vcunat
Copy link
Member

vcunat commented May 26, 2019

3d support seems to rely on VBoxOGL.so being symlinked from libGL.so (which we can't)

I actually don't see a problem to do such a symlink; "vboxvideo" driver can be a special case that does that instead of using glvnd (we certainly did that years ago).

@flokli
Copy link
Contributor Author

flokli commented May 26, 2019

yes, I explained in more detail in #18457 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @vcunat @infinisil