Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boohu: switching to termbox-go build #62044

Merged
merged 1 commit into from Jun 16, 2019
Merged

boohu: switching to termbox-go build #62044

merged 1 commit into from Jun 16, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 25, 2019

This is necessary for a better user experience.
File with go dependencies (deps.nix) was added.
Minor changes: name replaced by pname, quotes for url.

Motivation for this change

Improve the user experience of the game, make some small fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

boohu: switching to termbox-go build
90ad0fd 
This is necessary for a better user experience.
File with go dependencies (deps.nix) was added.
Minor changes: name replaced by pname, quotes for url.
@andir
Copy link
Member

andir commented Jun 16, 2019

@freepotion can you elaborate what the better user experience piece is? I am unfamiliar with the package but willing to work on this with you. Since you are listed as maintainer I kind of trust you with the application specific part :)

@ghost
Copy link
Author

ghost commented Jun 16, 2019

@andir In short: initially I wanted to give up unnecessary dependencies, but the use of termbox-go is provided by the developers by default. I tried and the game is really nicer with it than using only the standard go libraries. Also, I wanted to align with the new package I've recently created (#62030 This is a new roguelike, a fork of the boohu). 👽

@andir andir self-assigned this Jun 16, 2019
@andir andir merged commit 04a7ef5 into NixOS:master Jun 16, 2019
@ghost
Copy link
Author

ghost commented Jun 17, 2019

@andir Thanks! 👽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andir andir

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andir