Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: update cargoSha256 hashes for cargo-vendor upgrade #62047

Closed
wants to merge 93 commits into from

Conversation

alyssais
Copy link
Member

Motivation for this change

A recent upgrade of cargo-vendor changed its output slightly, which broke all cargoSha256 hashes in nixpkgs. See #60668 for more information.

Since then, a few hashes have been fixed in master by hand, but there were a lot still to do, so I did all of the ones left over with some scripts I wrote. Once this is merged, I can run the same scripts on the release branch that the cargo-vendor upgrade has made it into.

I’ve tested that this doesn’t break any builds on master. The actual target of the PR is staging, though, because of the number of rebuilds. The one hash I wasn’t able to update was habitat’s, because it’s currently broken and the build doesn’t get far enough to produce a hash anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member Author

OfBorg will fail here, because some of the packages whose dependencies I’ve fixed are broken for other reasons. Not a reason to avoid merging.

@lilyball
Copy link
Member

Looks like it's purely just cargoSha256 updates, so that seems simple enough. I wanted to spot-check at least one of them but trying to build it from your branch needs to rebuild a ton of dependencies which I don't have time for, oh well.

@infinisil
Copy link
Member

infinisil commented May 26, 2019

I don't think staging is needed though. This is just ~100 rebuilds of packages without any reverse dependencies, which shouldn't be a problem on master. As far as I understand, staging is mostly useful to group together mass updates like stdenv or other packages deep down the dependency tree.

@alyssais
Copy link
Member Author

alyssais commented May 26, 2019 via email

@alyssais
Copy link
Member Author

alyssais commented Jun 1, 2019

Merged to master as 062210b.

@alyssais alyssais closed this Jun 1, 2019
@alyssais alyssais deleted the cargo-sha256 branch June 1, 2019 15:24
@boj boj mentioned this pull request Jun 14, 2019
10 tasks
@alyssais alyssais mentioned this pull request Dec 19, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants