Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim_configurable: build against gtk{2,3}-x11 instead of gtk{2,3} to fix builds on darwin #62018

Merged
merged 1 commit into from May 24, 2019

Conversation

dhruvio
Copy link
Contributor

@dhruvio dhruvio commented May 24, 2019

Motivation for this change

vim_configurable fails to build on macOS. You can reproduce the failure by running nix-build -A vim_configurable ~/.nix-defexpr/channels/nixpkgs/default.nix when using the unstable channel.

This commit builds on the work by @smaret from #61912 and #61942 , by using gtk{2,3}-x11 dependencies that override cairo to work on Darwin.

Related to #61891.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer merged commit 0b0265a into NixOS:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants