Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txr: 209 -> 216 #61929

Merged
merged 3 commits into from Jun 4, 2019
Merged

txr: 209 -> 216 #61929

merged 3 commits into from Jun 4, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 23, 2019

Motivation for this change

Versions 210-215 crashed during tests,
but this one looks good! Enjoy!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
txr: 209 -> 216
f9dfeab 
Versions 210-215 crashed during tests,
but this one looks good! Enjoy!
tomberek
tomberek approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs on Ubuntu.
Did NOT check Darwin. Note ofborg failure.

@grahamc
Copy link
Member

grahamc commented May 23, 2019

@GrahamcOfBorg build txr

@infinisil
Copy link
Member

Can confirm the same failure on my mac. I suggest disabling darwin

@dtzWill
Copy link
Member Author

dtzWill commented May 31, 2019

Hmm, well not sure what's going on but it looks like upstream provides OSX prebuilt binaries for this?

https://bintray.com/kazinator/Binaries/TXR/

Or is this something that might be NixOS+Darwin specific?

@dtzWill dtzWill merged commit 9639420 into NixOS:master Jun 4, 2019
@dtzWill dtzWill deleted the update/txr-216 branch June 4, 2019 09:29
@dtzWill
Copy link
Member Author

dtzWill commented Jun 4, 2019

@infinisil or @grahamc : I'd like to poke a bit at the Darwin failure--and email upstream to see if they have any ideas (or it's a bug in which case I'm glad to have reported it :)). Anyway I can't seem to get the full build log from any of the failed attempts, only the summaries. And the full log for the last build which just says "no attempt since disabled on this platform" in its own way :).

Can either of you help -- grab me a build log from a failure? I suppose ideally we'd do it with some of TXR's debug/checking but for a first pass just seeing the failure would be good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @grahamc @infinisil @tomberek