Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose makeLinuxHeaders function from nixos/kernel-headers #61938

Merged
merged 1 commit into from May 24, 2019
Merged

Expose makeLinuxHeaders function from nixos/kernel-headers #61938

merged 1 commit into from May 24, 2019

Conversation

lostman
Copy link
Contributor

@lostman lostman commented May 23, 2019

Motivation for this change

While it is easy to switch the kernel or make a custom kernel by applying kernelPatches it is not so easy to get the corresponding headers; the derivation for linuxHeaders uses a hard-coded version.

This PR exposes a function that takes care of that. It is just a minor refactor of the (not exported) function common already present in kernel-headers/default.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lostman
nixos/kernel-headers: makeLinuxHeaders
5a7c98d 
While it is easy to make a custom kernel by applying kernelPatches it is
not so easy to get the corresponding headers; the derivation uses a
hard-coded kernel version.
@infinisil infinisil merged commit e93dfb2 into NixOS:master May 24, 2019
@knedlsepp
Copy link
Member

How would you use this? Cannot seem to find this when in nix repl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lostman @knedlsepp @infinisil @Janik-Haag