Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: 0.11.13 -> 0.11.14 & 0.12.0-rc1 -> 0.12.0 #61939

Merged
merged 2 commits into from May 23, 2019
Merged

terraform: 0.11.13 -> 0.11.14 & 0.12.0-rc1 -> 0.12.0 #61939

merged 2 commits into from May 23, 2019

Conversation

basvandijk
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member Author

The builds on x86_64-darwin look to be failing due to some resource exhaustion instead of a broken build. It builds successfully on my Macbook so this should be safe to merge.

@basvandijk basvandijk merged commit edb1668 into NixOS:master May 23, 2019
@basvandijk basvandijk mentioned this pull request May 23, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@basvandijk