harmonist: init at 0.1 #62030
Merged
harmonist: init at 0.1 #62030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
JohnAZoidberg
approved these changes
May 25, 2019
pkgs/games/harmonist/default.nix
Outdated
| management and character building, relying on items and player | ||
| adaptability for character progression. | ||
| ''; | ||
| homepage = https://harmonist.tuxfamily.org/; |
There was a problem hiding this comment.
Hint: We're going to deprecate unquoted URL syntax soon, if RFC 45 if approved.
There was a problem hiding this comment.
If you do the change from name to pname, you can update this as well.
|
@GrahamcOfBorg build harmonist |
etu
reviewed
May 25, 2019
pkgs/games/harmonist/default.nix
Outdated
|
|
||
| buildGoPackage rec { | ||
|
|
||
| name = "harmonist-${version}"; |
There was a problem hiding this comment.
Can be replaced by pname = "harmonist";. Then name will be built by itself.
etu
approved these changes
May 25, 2019
There was a problem hiding this comment.
Looks good overall, it would be great if you could look into the notes left by me and @JohnAZoidberg and then I have no problem with merging this.
|
@etu @JohnAZoidberg It's done. 馃懡 |
etu
reviewed
May 25, 2019
|
@freepotion Thanks! :) |
|
@etu Thank you too! :) |
ghost
mentioned this pull request
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To add a new roguelike game.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)馃懡