Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e243396c6f5f
Choose a base ref
...
head repository: solvespace/solvespace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 31f58738f21f
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on May 23, 2019

  1. Add a few asserts. NFC.

    @rpavlik @whitequark
    rpavlik authored and whitequark committed May 23, 2019
    Copy the full SHA
    31f5873 View commit details
Showing with 3 additions and 2 deletions.
  1. +2 −2 src/mesh.cpp
  2. +1 −0 src/srf/surface.cpp
4 changes: 2 additions & 2 deletions src/mesh.cpp
View file
Original file line number Diff line number Diff line change
@@ -289,8 +289,8 @@ void SMesh::MakeFromDifferenceOf(SMesh *a, SMesh *b) {
}

void SMesh::MakeFromCopyOf(SMesh *a) {
int i;
for(i = 0; i < a->l.n; i++) {
ssassert(this != a, "Can't make from copy of self");
for(int i = 0; i < a->l.n; i++) {
AddTriangle(&(a->l.elem[i]));
}
}
1 change: 1 addition & 0 deletions src/srf/surface.cpp
View file
Original file line number Diff line number Diff line change
@@ -829,6 +829,7 @@ void SShell::MakeFromRevolutionOf(SBezierLoopSet *sbls, Vector pt, Vector axis,
}

void SShell::MakeFromCopyOf(SShell *a) {
ssassert(this != a, "Can't make from copy of self");
MakeFromTransformationOf(a,
Vector::From(0, 0, 0), Quaternion::IDENTITY, 1.0);
}