Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x265: 2.9 -> 3.0 #62019

Merged
merged 1 commit into from May 26, 2019
Merged

x265: 2.9 -> 3.0 #62019

merged 1 commit into from May 26, 2019

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Update to 3.0

Also, since version 2.6, x265 it's using nasm instead of yasm, see https://bitbucket.org/multicoreware/x265/src/feec4bdf98663ac4a2561b63e1ccec423c7d26a4/build/README.txt#lines-37
That means that the x265 version from nix, wasn't using any of the CPU optimizations

I also compiled with NUMA support by default. Not 100% sure, but it seems that NUMA systems will get a big performance win, while for non NUMA systems this change should be un-noticeable. For more info see:
https://bitbucket.org/multicoreware/x265/commits/62b8fe990df5e560834e9b567a913238d8dd398e
https://bitbucket.org/multicoreware/x265/issues/108/numa-pools

I compressed a short video (~1 minute) with the same options, and the performance change was huge, it went down from 22 to 8 minutes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Note: Original PR was #61103

@jlesquembre jlesquembre mentioned this pull request May 24, 2019
Closed
10 tasks
@jlesquembre
Copy link
Member Author

@c0bw3b I addressed your feedback from #61103 here. Thanks for looking into it, and sorry for my mistake and all the noise.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 24, 2019

Changelog for the record:
https://x265.readthedocs.io/en/latest/releasenotes.html#version-3-0

Let's check Darwin build too:
@GrahamcOfBorg build x265

c0bw3b
c0bw3b approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built handbrake with x265 v3.0 locally and tried a simple encode from H.264 to H.265 without any issue.

@c0bw3b c0bw3b merged commit c104260 into NixOS:staging May 26, 2019
@jlesquembre jlesquembre deleted the x265-30 branch September 12, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlesquembre @c0bw3b