buildGoModule: pre-initialize module cache #61967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some Go projects a go.mod file is included but there are no listed dependencies. When this is encountered the Go toolchain will not create a cache folder for downloaded dependencies which causes buildGoModule to fail. An example of a project like this that is widely used is: https://github.com/golang/protobuf This commit adds a mkdir command to ensure that the directory always exists so it can be copied and prevent the failure.
johnchildren
changed the title
|
@GrahamcOfBorg build pet jx hugo proto-contrib amass termshark jump |
kalbasit
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some Go projects a go.mod file is included but there are no listed
dependencies. When this is encountered the Go toolchain will not create
a cache folder for downloaded dependencies which causes buildGoModule to
fail.
An example of a project like this that is widely used is:
https://github.com/golang/protobuf
This commit adds a mkdir command to ensure that the directory always
exists so it can be copied and prevent the failure.
An example of this before and after my patch:
https://github.com/johnchildren/nix-empty-go-modules/tree/master
https://github.com/johnchildren/nix-empty-go-modules/tree/fix-demonstration
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)