Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coexistence of "In Workplane" and "Anywhere in 3d" #197

Closed
wpwrak opened this issue Feb 10, 2017 · 14 comments · Fixed by #698
Closed

coexistence of "In Workplane" and "Anywhere in 3d" #197

wpwrak opened this issue Feb 10, 2017 · 14 comments · Fixed by #698
Milestone

Comments

@wpwrak
Copy link
Contributor

wpwrak commented Feb 10, 2017

It it possible to make the "Sketch" menu show that both "In Workplane" and "Anywhere in 3d" are selected. Schroedinger would approve :-)

schroedingers-workplane

I've seen this on several occasions. Here is a somewhat circuitous way to reproduce it. I'm still looking for a simpler one.

solvespace master (f29d9d7) plus small local changes
Let's use this example from https://gitlab.com/anelok/mexp.git master (3acc289)

  • New
  • assemble alt13/oled13.slvs
  • select the point in the lower left corner of the panel
  • select the origin and make both coincident (O)
  • this produces an "unsolveable constraints" error (for a reason I haven't investigated yet)
  • Undo
  • select Sketch > In workplane (it has changed to "Anywhere in 3d")
  • click away the complaint
  • open Sketch > and be amazed
@wpwrak
Copy link
Contributor Author

wpwrak commented Feb 10, 2017

Here is a shorter sequence:

  • New
  • assemble oled13.slvs (probably works with anything)
  • Sketch -> Anywhere in 3d
  • Sketch -> In Workplane
  • click away the complaint
  • Sketch > ... and there it is again

Note that, if we leave out the assembly step, we just get "In Workplane", as expected.

@whitequark whitequark added the bug label Feb 12, 2017
@whitequark whitequark added this to the 3.0 milestone Feb 17, 2017
@Evil-Spirit
Copy link
Collaborator

@wpwrak, It seems I can't reproduce it on Windows. And it's strange how the following code can cause this:

    RadioMenuByCmd(Command::FREE_IN_3D, !locked);
    RadioMenuByCmd(Command::SEL_WORKPLANE, locked);

@Evil-Spirit
Copy link
Collaborator

@Schroedinger, can you explain it?

@Evil-Spirit Evil-Spirit added this to indev in Evil-Spirit tasks Feb 17, 2017
@whitequark
Copy link
Contributor

Seems like UB...

@wpwrak
Copy link
Contributor Author

wpwrak commented Feb 18, 2017

UB = Ubuntu ? Yes, I'm on Ubuntu 16.10. I can collapse the quantum state (i.e., make it check only "Anywhere in 3d") by
https://0bin.net/paste/+c+6P42giR2hZiEl#AiwOfsiLHdPNCg2AOPR7Y3cM4g6xA2pY44gebEJmW7m
But I don't really know what I'm doing there, and if this may have nasty side-effects.

@Evil-Spirit Evil-Spirit moved this from indev to todev in Evil-Spirit tasks Feb 18, 2017
@ghost
Copy link

ghost commented Mar 2, 2017

UB = Ubuntu ? Yes, I'm on Ubuntu 16.10

@wpwrak, What build of SolveSpace you use on Yakety now? Is it possible run it on Xenial?

@wpwrak
Copy link
Contributor Author

wpwrak commented Mar 3, 2017

@Symbian9: I just build from sources, with a number of fixes and improvement, either from @Evil-Spirit or self-made, that are not in mainline. Not sure about Xenial.

@whitequark whitequark removed this from todev in Evil-Spirit tasks Apr 8, 2017
@whitequark whitequark added UI and removed UI labels Jul 12, 2018
@whitequark
Copy link
Contributor

@wpwrak Are you still able to reproduce this? I've refactored a lot of the UI code in the meantime.

@whitequark whitequark removed this from the 3.0 milestone May 23, 2019
@whitequark
Copy link
Contributor

Have not been able to reproduce for two years, and no response in two months, closing.

@whitequark
Copy link
Contributor

I was able to reproduce it.

  1. Draw a rectangle
  2. Extrude it
  3. Hit 2

@whitequark
Copy link
Contributor

OK, I figured it out. This is caused by rather obnoxious GTK behavior where set_active is not independent from causing a trigger event.

@whitequark whitequark added this to the 3.0 milestone Aug 15, 2019
@whitequark
Copy link
Contributor

@phkahler I'm pretty sure this is not fixed--the underlying issue is the behavior of set_active in GTK which retriggers the action.

@phkahler
Copy link
Member

@phkahler I'm pretty sure this is not fixed--the underlying issue is the behavior of set_active in GTK which retriggers the action.

What do you mean? On the surface this seems to fix it. Are you saying the condition may reappear?

@whitequark
Copy link
Contributor

Are you saying the condition may reappear?

I don't know how to trigger it, but there is still a latent bug left in the GTK UI code, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants