Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvirc: init at 5.0.0 #61976

Merged
merged 1 commit into from May 25, 2019
Merged

kvirc: init at 5.0.0 #61976

merged 1 commit into from May 25, 2019

Conversation

suhr
Copy link
Contributor

@suhr suhr commented May 23, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@suhr
Copy link
Contributor Author

suhr commented May 24, 2019

r?

aanderse
aanderse requested changes May 25, 2019
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build kvirc

@aanderse aanderse merged commit 10ed05e into NixOS:master May 25, 2019
@aanderse
Copy link
Member

@suhr Thanks for your contribution! 🎉

@suhr suhr deleted the kvirc branch May 25, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suhr @aanderse