Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: enable parallel builds #62022

Merged
merged 1 commit into from May 27, 2019
Merged

sqlite: enable parallel builds #62022

merged 1 commit into from May 27, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented May 24, 2019 •
edited

Motivation for this change

Saves a few seconds and documents that this builds just fine with -j.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented May 24, 2019

@GrahamcOfBorg build sqlite

@ofborg ofborg bot requested a review from edolstra May 24, 2019 21:19
tomberek
tomberek approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine on non-nixos.

@edolstra edolstra merged commit 71bc5e2 into NixOS:staging May 27, 2019
@bhipple bhipple deleted the fix/sqlite-parallel branch July 16, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@teto teto teto approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bhipple @tomberek @teto @vcunat @praetorg @edolstra