Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsUnstable: 0.8.0-rc5 -> 0.8.0 #61969

Merged
merged 1 commit into from May 24, 2019
Merged

zfsUnstable: 0.8.0-rc5 -> 0.8.0 #61969

merged 1 commit into from May 24, 2019

Conversation

aij
Copy link
Contributor

@aij aij commented May 23, 2019

Technically, this is a stable release, but it seems
prudent to test as zfsUnstable before upgrading zfsStable.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Technically, this is a stable release, but it seems
prudent to test as zfsUnstable before upgrading zfsStable.
@Izorkin
Copy link
Contributor

Izorkin commented May 23, 2019

@GrahamcOfBorg build linuxPackages_latest_hardened.zfsUnstable linuxPackages_hardened.zfsUnstable linuxPackages.zfsUnstable linuxPackages_latest.zfsUnstable
@GrahamcOfBorg test zfs

Test with nix-build nixos/tests/zfs.nix - working.

@Mic92 Mic92 merged commit cb950a8 into NixOS:master May 24, 2019
@Mic92
Copy link
Member

Mic92 commented May 24, 2019

Hit me up here or on IRC, when this has entered the unstable channel for a week or so and I will also update zfsStable.

@fpletz
Copy link
Member

fpletz commented May 29, 2019

@Mic92 We should also backport this to 19.03, right?

edit: Not the zfsStable bump of course but this very commit. 😸

@Mic92
Copy link
Member

Mic92 commented May 29, 2019

@fpletz yes. We also want to support newer kernels that we backport to 19.03 as well.

@Mic92
Copy link
Member

Mic92 commented May 29, 2019

19.03 backport: #62222

@ashkitten
Copy link
Contributor

i've been running zfsUnstable for the better part of a year with no issues, btw

@aij
Copy link
Contributor Author

aij commented Jun 4, 2019

@Mic92 It's now been on nixpkgs-unstable for just over a week.

@Mic92 Mic92 mentioned this pull request Jun 6, 2019
10 tasks
@ashkitten
Copy link
Contributor

0.8.1 has just been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants