Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages: update various python packages #62037

Closed
wants to merge 9 commits into from
Closed

pythonPackages: update various python packages #62037

wants to merge 9 commits into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

marsam added 9 commits May 24, 2019 20:00

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
To prevent infinite recursion with pytest

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
@FRidh
Copy link
Member

FRidh commented May 25, 2019

Do not merge this, because this has a significant impact and will break packages.

@marsam marsam mentioned this pull request May 31, 2019
10 tasks
@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

I forgot about this...

@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

Pushed the changes to python-unstable branch, evaluating now.

@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

Included in #63169

@FRidh FRidh closed this Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants