Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not initialized unnamed structures in Visual Studio #93

Closed
Evil-Spirit opened this issue Oct 22, 2016 · 8 comments
Closed

Not initialized unnamed structures in Visual Studio #93

Evil-Spirit opened this issue Oct 22, 2016 · 8 comments
Milestone

Comments

@Evil-Spirit
Copy link
Collaborator

Evil-Spirit commented Oct 22, 2016

Some of the structures not initialized with zero even with brace initialization.

@Evil-Spirit Evil-Spirit changed the title not initialized Not initialized unnamed structures in Visual Studio Oct 22, 2016
@Evil-Spirit
Copy link
Collaborator Author

This is also can be included Evil-Spirit/solvespace@e07404a

@whitequark
Copy link
Contributor

whitequark commented Nov 17, 2016

The current master and opengl2 branches use the style like:

OpenGl1Renderer() : camera(), lighting(), current() {}

I cannot reproduce the bug on master or opengl2, when built with MSVC locally, or on Appveyor. Can you confirm that this problem is not present? Or show where the uninitialized data ends?

Note, camera{} is not the same as camera() so that's probably why I don't get the error...

@Evil-Spirit
Copy link
Collaborator Author

@whitequark,
Yes, I still have this problem on master (GL Error 0x502).
This is because current.drawing not initialized with false

@whitequark
Copy link
Contributor

OK, I'll look further into it.

@whitequark whitequark modified the milestone: 3.0 Nov 18, 2016
@whitequark
Copy link
Contributor

whitequark commented Nov 29, 2016

@Evil-Spirit May be similar to 86f0439.

@Evil-Spirit
Copy link
Collaborator Author

@whitequark, yes this bugs of the same nature.

Evil-Spirit added a commit to Evil-Spirit/solvespace-master that referenced this issue Feb 21, 2017
@Evil-Spirit
Copy link
Collaborator Author

Evil-Spirit commented Mar 2, 2017

@whitequark
Copy link
Contributor

@Evil-Spirit I finally figured it out, should be fixed in 43a59e2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants