Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages: fix bignums and equations #61948

Merged
merged 1 commit into from May 24, 2019
Merged

coqPackages: fix bignums and equations #61948

merged 1 commit into from May 24, 2019

Conversation

CohenCyril
Copy link
Contributor

@CohenCyril CohenCyril commented May 23, 2019 •
edited

Motivation for this change

The versions for coqPackages bignums and equations were outdated

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril
Copy link
Contributor Author

@vbgl could you trigger a build?

@vbgl
Copy link
Contributor

vbgl commented May 23, 2019

@GrahamcOfBorg build coqPackages_8_6.bignums coqPackages_8_7.bignums coqPackages_8_8.bignums coqPackages_8_9.bignums

@vbgl
Copy link
Contributor

vbgl commented May 23, 2019

@GrahamcOfBorg build coqPackages_8_8.equations coqPackages_8_9.equations

@infinisil infinisil merged commit 9aa60e6 into NixOS:master May 24, 2019
@CohenCyril CohenCyril deleted the bignums_equations_update branch May 24, 2019 13:43
@vbgl
Copy link
Contributor

vbgl commented Jun 3, 2019

This broke category-theory, didn’t it?

@CohenCyril
Copy link
Contributor Author

This broke category-theory, didn’t it?

yes apparently it did.

@CohenCyril
Copy link
Contributor Author

Hi @vbgl what is the policy for this? should we

  • revert equation to an older version?
  • or create a new attribute for the old version and use it in the now-broken package
  • or mark the package as broken?
  • or another solution?

@vbgl
Copy link
Contributor

vbgl commented Jun 4, 2019

ping @jwiegley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CohenCyril @vbgl @infinisil