Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a constraint identical to an existing one should be no-op instead of unsat #301

Closed
azonenberg opened this issue Nov 8, 2017 · 2 comments
Closed

Adding a constraint identical to an existing one should be no-op instead of unsat #301

azonenberg opened this issue Nov 8, 2017 · 2 comments
Labels
enhancement
Milestone
3.0

Comments

@azonenberg
Copy link

As of now, when you add a horizontal, vertical, etc constraint to a line, and one already exists, the solver declares the design unsatisfiable. The user's intention was probably to make that line go in the direction it's already in, so adding a second identical constraint should be a legal no-op (keep the existing constraint and don't add a new one).
@whitequark whitequark changed the title Enhancement: Adding a constraint identical to an existing one should be no-op instead of unsat Adding a constraint identical to an existing one should be no-op instead of unsat Nov 8, 2017
@Evil-Spirit
Copy link
Collaborator

This is very resonable and we can do the same for other types of solver errors. We can intorduce optional checkbox: Solver silent mode enabled by default (easy for new users).

  1. Redundant constraint without value label -> remove immediate with error msgbox
  2. Redundant constraint with value label -> add it like reference (actually implemented)
  3. Didn't converge while adding constraint -> remove immediate with error msgbox
  4. Didn't converge while dragging -> just undo to pervious valid position

@marthinwurer marthinwurer mentioned this issue Oct 6, 2018
Closed
@whitequark whitequark added this to the 3.0 milestone May 24, 2019
@whitequark
Copy link
Contributor

Fixed in 406c55e.

Instead of just being a no-op, I select the existing constraint, so that you can see feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@whitequark @azonenberg @Evil-Spirit