Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcpc: move libdsk and lesstiff as optional #61982

Merged
merged 1 commit into from May 26, 2019
Merged

xcpc: move libdsk and lesstiff as optional #61982

merged 1 commit into from May 26, 2019

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented May 24, 2019 •
edited

Motivation for this change

optional lesstif should make it works on ARM (tested with pkgsCross.raspberryPi.xcpc )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bignaux bignaux changed the title xcpc: move libsdk and lesstiff as optional xcpc: move libdsk and lesstiff as optional May 24, 2019
aanderse
aanderse approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aanderse aanderse merged commit 5dc4d65 into NixOS:master May 26, 2019
@bignaux bignaux deleted the xcpc branch May 26, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bignaux @aanderse